Version 4.5.103.15 (cherry-pick)

Version 4.5.103.15 (cherry-pick)

Merged 8ae236c0c4bcc7218f2f2dcf909c1410b9ce065e

Fix the failure when enabling v8 profiler or vtune profiler in chromium.

R=hablich@chromium.org
BUG=v8:4352
Committed: https://chromium.googlesource.com/v8/v8/+/71d2ce6b04113387360b4814b817ed046b14ebcf

[chunyang.dai, 2015-08-05 08:52:58]

Hi, Michael.
I created one issue v8:4352 to track this issue according to the wiki. Please
review it.

Because my computer is restarted and my previous back-port session is closed. So
I have to create this new CL. The original CL
https://codereview.chromium.org/1254133005/ cannot be continued.  :(

thank.

[Michael Hablich, 2015-08-05 11:40:26]

On 2015/08/05 08:52:58, chunyang.dai wrote:
> Hi, Michael.
> I created one issue v8:4352 to track this issue according to the wiki. Please
> review it.
> 
> Because my computer is restarted and my previous back-port session is closed.
So
> I have to create this new CL. The original CL
> https://codereview.chromium.org/1254133005/ cannot be continued.  :(
> 
> thank.

lgtm

[chunyang.dai, 2015-08-05 15:38:41]

Committed patchset #1 (id:1) manually as
71d2ce6b04113387360b4814b817ed046b14ebcf.

[Jakob Kummerow, 2015-08-07 09:20:12]

jkummerow@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2015-08-07 09:20:12]

So this didn't go well at all. The commit description is wrong (this is
4.5.103.20 now), and there is no tag (presumably because the script tried to
create the .15 tag which existed already).

When backmerge script runs are outdated (because other merges went in in the
meantime), they must be restarted from scratch, not just manually fixed to
apply.
More generally, doing backmerges with several hours of latency is not a good
workflow. Before starting a backmerge, ping a potential reviewer on chat.

[Michael Hablich, 2015-08-07 10:30:19]

On 2015/08/07 09:20:12, Jakob wrote:
> So this didn't go well at all. The commit description is wrong (this is
> 4.5.103.20 now), and there is no tag (presumably because the script tried to
> create the .15 tag which existed already).
> 
> When backmerge script runs are outdated (because other merges went in in the
> meantime), they must be restarted from scratch, not just manually fixed to
> apply.
> More generally, doing backmerges with several hours of latency is not a good
> workflow. Before starting a backmerge, ping a potential reviewer on chat.

A good, general advise. I just tagged the commit.