Issue 1254133005: Version 4.5.103.15 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1254133005: Version 4.5.103.15 (cherry-pick) (Closed)

Created:
5 years, 4 months ago by chunyang.dai

Modified:
5 years, 3 months ago

Reviewers:
ulan, Michael Hablich

CC:
v8-dev, Paweł Hajdan Jr., ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@4.5

Target Ref:
refs/pending/branch-heads/4.5

Project:
v8

Visibility:
Public.

More Reviews

Description

Version 4.5.103.15 (cherry-pick) Merged 8ae236c0c4bcc7218f2f2dcf909c1410b9ce065e Fix the failure when enabling v8 profiler or vtune profiler in chromium. R=ulan@chromium.org BUG=v8:4352

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	include/v8-version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/heap/heap.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

chunyang.dai

Hi, Hablich. Please help to check this porting patch. Thanks.

5 years, 4 months ago (2015-08-04 02:42:17 UTC) #3

Michael Hablich

On 2015/08/04 02:42:17, chunyang.dai wrote: > Hi, Hablich. > Please help to check this porting ...

5 years, 4 months ago (2015-08-04 07:51:35 UTC) #4

Michael Hablich

5 years, 4 months ago (2015-08-05 08:47:17 UTC) #5

On 2015/08/04 07:51:35, Hablich wrote:
> On 2015/08/04 02:42:17, chunyang.dai wrote:
> > Hi, Hablich. 
> >  Please help to check this porting patch.
> >  Thanks.
> 
> Hi Chunyang,
> 
> please create an issue on the V8 issue tracker and reference to it in this CL.
> Additionally please CC me on the issue. See also
> https://code.google.com/p/v8-wiki/wiki/MergingAndPatching for more
information.
> 
> Thanks,
> Michael

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages