Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Unified Diff: components/autofill/browser/form_structure_unittest.cc

Issue 12721004: Autofill:Autocomplete: Enable autocheckout of input elements of type password. This will support fi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/form_structure_unittest.cc
diff --git a/components/autofill/browser/form_structure_unittest.cc b/components/autofill/browser/form_structure_unittest.cc
index abbe1aa4e03be30768d0c6a1239e00717fef6e6b..7a363038ae9ce42e032b3060d9dba79d64c90d1f 100644
--- a/components/autofill/browser/form_structure_unittest.cc
+++ b/components/autofill/browser/form_structure_unittest.cc
@@ -2145,6 +2145,12 @@ TEST(FormStructureTest, CheckFormSignature) {
field.name = ASCIIToUTF16("first");
form.fields.push_back(field);
+ // Password fields shouldn't effect the signature.
Ilya Sherman 2013/03/15 23:42:35 nit: "effect" -> "affect"
Raman Kakilate 2013/03/18 17:54:00 Done.
+ field.label = ASCIIToUTF16("Password");
+ field.name = ASCIIToUTF16("password");
+ field.is_password_field = true;
+ form.fields.push_back(field);
+
form_structure.reset(new FormStructure(form, std::string()));
EXPECT_EQ(FormStructureTest::Hash64Bit(

Powered by Google App Engine
This is Rietveld 408576698