components/autofill/browser/form_structure.cc - Issue 12721004: Autofill:Autocomplete: Enable autocheckout of input elements of type password. This will support fi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/form_structure.cc

Issue 12721004: Autofill:Autocomplete: Enable autocheckout of input elements of type password. This will support fi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/form_autofill_browsertest.cc ('k') | components/autofill/browser/form_structure_unittest.cc » ('j') | components/autofill/browser/form_structure_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/browser/form_structure.cc

diff --git a/components/autofill/browser/form_structure.cc b/components/autofill/browser/form_structure.cc

index 8dbf6bd5304ba8b2684ea32c8988d41eb32f53ca..67f60b67066cf473113eb3a8b5f1f4468aab0929 100644

--- a/components/autofill/browser/form_structure.cc

+++ b/components/autofill/browser/form_structure.cc

@@ -247,7 +247,8 @@ FormStructure::FormStructure(const FormData& form,

// Skipping checkable elements when Autocheckout is not enabled, else

// these fields will interfere with existing field signatures with Autofill

// servers.

- if (!field->is_checkable || IsAutocheckoutEnabled()) {

+ if ((!field->is_checkable && !field->is_password_field) ||

Ilya Sherman 2013/03/15 23:43:27 You should also make sure that password fields do

Raman Kakilate 2013/03/18 17:54:00 Done.

+ IsAutocheckoutEnabled()) {

// Add all supported form fields (including with empty names) to the

// signature. This is a requirement for Autofill servers.

form_signature_field_names_.append("&");