Autofill:Autocomplete: Enable autocheckout of input elements of type password. This will support fi…

components/autofill/browser/form_structure.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/browser/form_structure.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 229 matching lines @@
       autocheckout_url_prefix_(autocheckout_url_prefix) {
   // Copy the form fields.
   std::map<string16, size_t> unique_names;
   for (std::vector<FormFieldData>::const_iterator field =
            form.fields.begin();
        field != form.fields.end(); field++) {
 
     // Skipping checkable elements when Autocheckout is not enabled, else
     // these fields will interfere with existing field signatures with Autofill
     // servers.
-    if (!field->is_checkable || IsAutocheckoutEnabled()) {
+    if ((!field->is_checkable && !field->is_password_field) ||

[Ilya Sherman, 2013/03/15 23:43:27]

You should also make sure that password fields do not contribute to the 3-field
minimum for issuing a request to the Autofill server.

[Raman Kakilate, 2013/03/18 17:54:00]

Done.

+        IsAutocheckoutEnabled()) {
       // Add all supported form fields (including with empty names) to the
       // signature.  This is a requirement for Autofill servers.
       form_signature_field_names_.append("&");
       form_signature_field_names_.append(UTF16ToUTF8(field->name));
     }
 
     // Generate a unique name for this field by appending a counter to the name.
     // Make sure to prepend the counter with a non-numeric digit so that we are
     // guaranteed to avoid collisions.
     if (!unique_names.count(field->name))
@@ skipping 887 matching lines @@
   for (std::vector<AutofillField*>::iterator field = fields_.begin();
        field != fields_.end(); ++field) {
     AutofillType::FieldTypeGroup field_type_group =
         AutofillType((*field)->type()).group();
     if (field_type_group == AutofillType::CREDIT_CARD)
       (*field)->set_section((*field)->section() + "-cc");
     else
       (*field)->set_section((*field)->section() + "-default");
   }
 }