Issue 1272043002: Merge to XFA: Remove stringify macro (#) from JS_STATIC_CONST_ENTRY_*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1272043002: Merge to XFA: Remove stringify macro (#) from JS_STATIC_CONST_ENTRY_*. (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove stringify macro (#) from JS_STATIC_CONST_ENTRY_*. (cherry picked from commit d539de991cacf02811880c434d4393c8275163d2) Original Review URL: https://codereview.chromium.org/1256283005 . R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e2bad47fa64137fdafacc0ca56434fccac4b028d

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -55 lines)			Patch
	M	fpdfsdk/include/javascript/JS_Define.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	fpdfsdk/src/javascript/Consts.cpp	View		9 chunks	+53 lines, -53 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

5 years, 4 months ago (2015-08-04 21:31:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e2bad47fa64137fdafacc0ca56434fccac4b028d (presubmit successful).