Issue 1256283005: Remove stringify macro (#) from JS_STATIC_CONST_ENTRY_*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1256283005: Remove stringify macro (#) from JS_STATIC_CONST_ENTRY_*. (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove stringify macro (#) from JS_STATIC_CONST_ENTRY_*. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d539de991cacf02811880c434d4393c8275163d2

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -55 lines)			Patch
	M	fpdfsdk/include/javascript/JS_Define.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	fpdfsdk/src/javascript/Consts.cpp	View		9 chunks	+53 lines, -53 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Tom Sepez

Committed patchset #1 (id:1) manually as d539de991cacf02811880c434d4393c8275163d2 (presubmit successful).

5 years, 4 months ago (2015-08-04 20:56:48 UTC) #4

Lei Zhang

5 years, 4 months ago (2015-08-04 21:00:07 UTC) #5

Message was sent while issue was closed.

On 2015/08/04 20:56:48, Tom Sepez wrote:
> Committed patchset #1 (id:1) manually as
> d539de991cacf02811880c434d4393c8275163d2 (presubmit successful).

We can probably skip https://codereview.chromium.org/1269223002/ and just fix
this up when we merge to XFA.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages