Android: improve native debuggability

base/debug/debugger_posix.cc

Index: base/debug/debugger_posix.cc
diff --git a/base/debug/debugger_posix.cc b/base/debug/debugger_posix.cc
index 0fbefdebb722db6b2859cff73348df8058c68220..1c7c559bf871e5ee330de595f83b291568e96269 100644
--- a/base/debug/debugger_posix.cc
+++ b/base/debug/debugger_posix.cc
@@ -218,16 +218,18 @@ bool BeingDebugged() {
 // SIG triggered by native code.
 //
 // Use GDB to set |go| to 1 to resume execution.
-#define DEBUG_BREAK() do { \
-  if (!BeingDebugged()) { \
-    abort(); \
-  } else { \
-    volatile int go = 0; \
-    while (!go) { \
-      base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100)); \
-    } \
-  } \
-} while (0)
+void DEBUG_BREAK() {

[darin (slow to review), 2013/03/19 22:24:14]

nit: I recommend preserving the DEBUG_BREAK macro (in an effort to reduce
surprises between ports), and instead introduce a function that DEBUG_BREAK
resolves to.

void DebugBreak() {
  ...
}
#define DEBUG_BREAK() DebugBreak()

[mostynb%opera.com, 2013/03/20 05:32:39]

Done.

+  do {
+    if (!BeingDebugged()) {
+      abort();
+    } else {
+      volatile int go = 0;
+      while (!go) {
+        base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100));
+      }
+    }
+  } while (0);
+}
 #else
 // ARM && !ANDROID
 #define DEBUG_BREAK() asm("bkpt 0")