chrome/browser/notifications/sync_notifier/chrome_notifier_service.h - Issue 12717010: Widen Data Pipes and newer protobufs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/sync_notifier/chrome_notifier_service.h

Issue 12717010: Widen Data Pipes and newer protobufs (Closed) Base URL: http://git.chromium.org/chromium/src.git@newProtobufs

Patch Set: Synced Notifications newer protobufs - improve unit test robustness Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/sync_notifier/chrome_notifier_delegate.cc ('k') | chrome/browser/notifications/sync_notifier/chrome_notifier_service.cc » ('j') | chrome/browser/notifications/sync_notifier/chrome_notifier_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/sync_notifier/chrome_notifier_service.h

diff --git a/chrome/browser/notifications/sync_notifier/chrome_notifier_service.h b/chrome/browser/notifications/sync_notifier/chrome_notifier_service.h

index 4332e5110c0c6b9ba844582699a007ec1410808d..d2809a0792648cf04d66fb3bab1a1fd3ab3cd86d 100644

--- a/chrome/browser/notifications/sync_notifier/chrome_notifier_service.h

+++ b/chrome/browser/notifications/sync_notifier/chrome_notifier_service.h

@@ -54,7 +54,7 @@ class ChromeNotifierService : public syncer::SyncableService,

// Get a pointer to a notification. ChromeNotifierService owns this pointer.

// The caller must not free it.

- notifier::SyncedNotification* FindNotificationById(const std::string& id);

+ notifier::SyncedNotification* FindNotificationByKey(const std::string& key);

// Called when we dismiss a notification.

void MarkNotificationAsDismissed(const std::string& id);