chrome/browser/notifications/sync_notifier/chrome_notifier_delegate.cc - Issue 12717010: Widen Data Pipes and newer protobufs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/sync_notifier/chrome_notifier_delegate.cc

Issue 12717010: Widen Data Pipes and newer protobufs (Closed) Base URL: http://git.chromium.org/chromium/src.git@newProtobufs

Patch Set: Synced Notifications newer protobufs - improve unit test robustness Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification.h ('k') | chrome/browser/notifications/sync_notifier/chrome_notifier_service.h » ('j') | chrome/browser/notifications/sync_notifier/chrome_notifier_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/sync_notifier/chrome_notifier_delegate.cc

diff --git a/chrome/browser/notifications/sync_notifier/chrome_notifier_delegate.cc b/chrome/browser/notifications/sync_notifier/chrome_notifier_delegate.cc

index 1348d170dfd4a50a717953e1b5492753d9c783d9..f61714e127eed194e970852b72580b15b3f6cc00 100644

--- a/chrome/browser/notifications/sync_notifier/chrome_notifier_delegate.cc

+++ b/chrome/browser/notifications/sync_notifier/chrome_notifier_delegate.cc

@@ -22,7 +22,8 @@ content::RenderViewHost* ChromeNotifierDelegate::GetRenderViewHost() const {

}

void ChromeNotifierDelegate::Close(bool by_user) {

- chrome_notifier_->MarkNotificationAsDismissed(id_);

+ if (by_user)

+ chrome_notifier_->MarkNotificationAsDismissed(id_);

}

} // namespace notifier