Issue 127163002: Relanding this change with the DesktopAuraTopLevelOwnedPopupResizeTest enabled only for Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 127163002: Relanding this change with the DesktopAuraTopLevelOwnedPopupResizeTest enabled only for Windows. (Closed)

Created:
6 years, 11 months ago by ananta

Modified:
6 years, 11 months ago

Reviewers:
ccameron

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Relanding this change with the DesktopAuraTopLevelOwnedPopupResizeTest enabled only for Windows. Revert 243438 "Revert 243413 "Resize the widget when top level p..." > Revert 243413 "Resize the widget when top level popup windows cr..." > > > Resize the widget when top level popup windows created by the content layer are resized. > > > > The content layer creates top level popup windows, for select items on a page for e.g. When these > > windows are resized we need to resize the parent widget hosting them. > > > > BUG=330596 > > TEST=Covered by views test DesktopAuraTopLevelOwnedPopupResizeTest > > R=sky@chromium.org > > > > Review URL: https://codereview.chromium.org/125203005 > > TBR=ananta@chromium.org > > Review URL: https://codereview.chromium.org/127073003 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243442

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -1 line)			Patch
	M	trunk/src/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View		2 chunks	+11 lines, -1 line	0 comments	Download
	M	trunk/src/ui/views/widget/widget_unittest.cc	View		2 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r243442.

Expand Messages | Collapse Messages