Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 125203005: Resize the widget when top level popup windows created by the content layer are resized. (Closed)

Created:
6 years, 11 months ago by ananta
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Visibility:
Public.

Description

Resize the widget when top level popup windows created by the content layer are resized. The content layer creates top level popup windows, for select items on a page for e.g. When these windows are resized we need to resize the parent widget hosting them. BUG=330596 TEST=Covered by views test DesktopAuraTopLevelOwnedPopupResizeTest R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243413

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ananta
6 years, 11 months ago (2014-01-07 00:39:53 UTC) #1
sky
https://codereview.chromium.org/125203005/diff/1/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc File ui/views/widget/desktop_aura/desktop_native_widget_aura.cc (right): https://codereview.chromium.org/125203005/diff/1/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc#newcode138 ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:138: if (top_level_widget_ && window != top_level_widget_->GetNativeView()) Rather than window ...
6 years, 11 months ago (2014-01-07 16:36:33 UTC) #2
ananta
https://codereview.chromium.org/125203005/diff/1/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc File ui/views/widget/desktop_aura/desktop_native_widget_aura.cc (right): https://codereview.chromium.org/125203005/diff/1/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc#newcode138 ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:138: if (top_level_widget_ && window != top_level_widget_->GetNativeView()) On 2014/01/07 16:36:33, ...
6 years, 11 months ago (2014-01-07 18:56:08 UTC) #3
sky
LGTM
6 years, 11 months ago (2014-01-07 21:40:10 UTC) #4
ananta
6 years, 11 months ago (2014-01-07 22:32:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r243413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698