Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 12716018: Remove defines by duplicating end_of_instruction_cleanup. (Closed)

Created:
7 years, 9 months ago by khim
Modified:
7 years, 9 months ago
Reviewers:
halyavin
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Remove defines by duplicating end_of_instruction_cleanup. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2597 TEST=trybots (no changes in logic) Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10998

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -245 lines) Patch
M src/trusted/validator_ragel/gen/decoder_x86_32.c View 13 chunks +20 lines, -58 lines 0 comments Download
M src/trusted/validator_ragel/gen/decoder_x86_64.c View 22 chunks +89 lines, -96 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/decoder_x86_32.rl View 1 3 chunks +25 lines, -35 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/decoder_x86_64.rl View 1 3 chunks +40 lines, -19 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/parse_instruction.rl View 1 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
khim
7 years, 9 months ago (2013-03-15 10:45:25 UTC) #1
halyavin
lgtm https://codereview.chromium.org/12716018/diff/1/src/trusted/validator_ragel/unreviewed/decoder_x86_64.rl File src/trusted/validator_ragel/unreviewed/decoder_x86_64.rl (right): https://codereview.chromium.org/12716018/diff/1/src/trusted/validator_ragel/unreviewed/decoder_x86_64.rl#newcode111 src/trusted/validator_ragel/unreviewed/decoder_x86_64.rl:111: /* Top three bis of VEX2 are inverted: ...
7 years, 9 months ago (2013-03-15 10:59:38 UTC) #2
khim
https://codereview.chromium.org/12716018/diff/1/src/trusted/validator_ragel/unreviewed/decoder_x86_64.rl File src/trusted/validator_ragel/unreviewed/decoder_x86_64.rl (right): https://codereview.chromium.org/12716018/diff/1/src/trusted/validator_ragel/unreviewed/decoder_x86_64.rl#newcode111 src/trusted/validator_ragel/unreviewed/decoder_x86_64.rl:111: /* Top three bis of VEX2 are inverted: see ...
7 years, 9 months ago (2013-03-15 11:03:21 UTC) #3
khim
7 years, 9 months ago (2013-03-15 11:28:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r10998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698