Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1271543002: Fix potential null pointer dereference. (Closed)

Created:
5 years, 4 months ago by liuandrew
Modified:
5 years, 4 months ago
Reviewers:
srutherford, ivanpe, mmandlis, ahonig
CC:
google-breakpad-dev_googlegroups.com, crash-team_google.com
Visibility:
Public.

Description

Fix potential null pointer dereference. If a MinidumpLinuxMapsList was created and destroyed without its Read method, the program would have a segmentation fault because the destructor did not check for a null maps_ field. Additional changes include additional supplementary null checks, a potential memory leak fix, and some comment removal. Committed: https://code.google.com/p/google-breakpad/source/detail?r=1478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M src/google_breakpad/processor/minidump.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/processor/minidump.cc View 4 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
liuandrew
5 years, 4 months ago (2015-07-31 15:14:37 UTC) #2
liuandrew
Committed patchset #1 (id:1) manually as r1478 (presubmit successful).
5 years, 4 months ago (2015-07-31 15:26:44 UTC) #3
mmandlis
5 years, 4 months ago (2015-07-31 15:26:57 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698