Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Side by Side Diff: src/google_breakpad/processor/minidump.h

Issue 1271543002: Fix potential null pointer dereference. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/processor/minidump.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 Google Inc. 1 // Copyright (c) 2010 Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 883 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 // Print the contents of this mapping. 894 // Print the contents of this mapping.
895 void Print(); 895 void Print();
896 896
897 private: 897 private:
898 // These objects are managed by MinidumpLinuxMapsList. 898 // These objects are managed by MinidumpLinuxMapsList.
899 friend class MinidumpLinuxMapsList; 899 friend class MinidumpLinuxMapsList;
900 900
901 // This caller owns the pointer. 901 // This caller owns the pointer.
902 explicit MinidumpLinuxMaps(Minidump *minidump); 902 explicit MinidumpLinuxMaps(Minidump *minidump);
903 903
904 // Read data about a single mapping from /proc/self/maps and load the data
905 // into this object. The input vector is in the same format as a line from
906 // /proc/self/maps.
907
908 // The memory region struct that this class wraps. 904 // The memory region struct that this class wraps.
909 MappedMemoryRegion region_; 905 MappedMemoryRegion region_;
910 906
911 DISALLOW_COPY_AND_ASSIGN(MinidumpLinuxMaps); 907 DISALLOW_COPY_AND_ASSIGN(MinidumpLinuxMaps);
912 }; 908 };
913 909
914 // MinidumpLinuxMapsList corresponds to the Linux-exclusive MD_LINUX_MAPS 910 // MinidumpLinuxMapsList corresponds to the Linux-exclusive MD_LINUX_MAPS
915 // stream, which contains the contents of /prod/self/maps, which contains 911 // stream, which contains the contents of /prod/self/maps, which contains
916 // the mapped memory regions and their access permissions. 912 // the mapped memory regions and their access permissions.
917 class MinidumpLinuxMapsList : public MinidumpStream { 913 class MinidumpLinuxMapsList : public MinidumpStream {
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
1120 // construction or after a failed Read(); true following a successful 1116 // construction or after a failed Read(); true following a successful
1121 // Read(). 1117 // Read().
1122 bool valid_; 1118 bool valid_;
1123 }; 1119 };
1124 1120
1125 1121
1126 } // namespace google_breakpad 1122 } // namespace google_breakpad
1127 1123
1128 1124
1129 #endif // GOOGLE_BREAKPAD_PROCESSOR_MINIDUMP_H__ 1125 #endif // GOOGLE_BREAKPAD_PROCESSOR_MINIDUMP_H__
OLDNEW
« no previous file with comments | « no previous file | src/processor/minidump.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698