Issue 1271423002: Update NOPRESUBMIT docs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1271423002: Update NOPRESUBMIT docs. (Closed)

Created:
5 years, 4 months ago by mtklein_C

Modified:
5 years, 4 months ago

Reviewers:
rmistry, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Update NOPRESUBMIT docs. "NOPRESUBMIT=true" does not work anymore for me. BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1271423002 Committed: https://skia.googlesource.com/skia/+/94df02344bd819a6aff0e9fdd31c2e9ba9bab34d

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	site/dev/contrib/cqkeywords.md	View		5 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmistry

LGTM. Yes you are right, it used to work before it was a trybot. One ...

5 years, 4 months ago (2015-08-05 20:02:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271423002/1

5 years, 4 months ago (2015-08-05 20:07:48 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-05 20:08:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/94df02344bd819a6aff0e9fdd31c2e9ba9bab34d

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages