Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: site/dev/contrib/cqkeywords.md

Issue 1271423002: Update NOPRESUBMIT docs. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Commit Queue Keywords 1 Commit Queue Keywords
2 ===================== 2 =====================
3 3
4 COMMIT 4 COMMIT
5 ------ 5 ------
6 6
7 If you are working on experimental code and do not want to risk accidentally 7 If you are working on experimental code and do not want to risk accidentally
8 submitting the change via the CQ, then you can mark it with "COMMIT=false". 8 submitting the change via the CQ, then you can mark it with "COMMIT=false".
9 The CQ will immediately abandon the change if it contains this option. 9 The CQ will immediately abandon the change if it contains this option.
10 To do a dry run through the CQ please use Rietveld's [dry run](https://groups.go ogle.com/a/chromium.org/forum/#!topic/chromium-dev/G5-X0_tfmok) feature. 10 To do a dry run through the CQ please use Rietveld's [dry run](https://groups.go ogle.com/a/chromium.org/forum/#!topic/chromium-dev/G5-X0_tfmok) feature.
11 11
12 COMMIT=false 12 COMMIT=false
13 13
14 The CQ will run through its list of verifiers (reviewer check, trybots, tree che ck, 14 The CQ will run through its list of verifiers (reviewer check, trybots, tree che ck,
15 presubmit check), and will close the issue instead of committing it. 15 presubmit check), and will close the issue instead of committing it.
16 16
17 NO_DEPENDENCY_CHECKS 17 NO_DEPENDENCY_CHECKS
18 -------------------- 18 --------------------
19 19
20 NO_DEPENDENCY_CHECKS=true 20 NO_DEPENDENCY_CHECKS=true
21 21
22 The CQ rejects patchsets with open dependencies. An open dependency exists when a CL 22 The CQ rejects patchsets with open dependencies. An open dependency exists when a CL
23 depends on another CL that is not yet closed. You can skip this check with this keyword. 23 depends on another CL that is not yet closed. You can skip this check with this keyword.
24 24
25 CQ_INCLUDE_TRYBOTS 25 CQ_INCLUDE_TRYBOTS
26 ------------------ 26 ------------------
27 27
28 Allows you to add arbitrary trybots to the CQ's list of default trybots. 28 Allows you to add arbitrary trybots to the CQ's list of default trybots.
29 The CQ will block till these tryjobs pass just like the default list of tryjobs. 29 The CQ will block till these tryjobs pass just like the default list of tryjobs.
30 30
31 This is the format of the values of this keyword: 31 This is the format of the values of this keyword:
32 32
33 CQ_INCLUDE_TRYBOTS=master1:bot1,bot2;master2:bot3,bot4 33 CQ_INCLUDE_TRYBOTS=master1:bot1,bot2;master2:bot3,bot4
34 34
35 Here are some real world examples: 35 Here are some real world examples:
36 36
37 CQ_INCLUDE_TRYBOTS=tryserver.chromium:linux_layout_rel 37 CQ_INCLUDE_TRYBOTS=tryserver.chromium:linux_layout_rel
38 38
39 CQ_INCLUDE_TRYBOTS=tryserver.skia:Build-Mac10.9-Clang-x86_64-Debug 39 CQ_INCLUDE_TRYBOTS=tryserver.skia:Build-Mac10.9-Clang-x86_64-Debug
40 40
41 CQ_EXCLUDE_TRYBOTS 41 CQ_EXCLUDE_TRYBOTS
42 ------------------ 42 ------------------
43 43
44 Allows you to remove trybots from the CQ's list of default trybots. Should only be 44 Allows you to remove trybots from the CQ's list of default trybots. Should only be
45 used when particular builders are failing for reasons unrelated to your code cha nges. 45 used when particular builders are failing for reasons unrelated to your code cha nges.
46 46
47 This is the format of the values of this keyword: 47 This is the format of the values of this keyword:
48 48
49 CQ_EXCLUDE_TRYBOTS=master1:bot1,bot2;master2:bot3,bot4 49 CQ_EXCLUDE_TRYBOTS=master1:bot1,bot2;master2:bot3,bot4
50 50
51 Here are some real world examples: 51 Here are some real world examples:
52 52
53 CQ_EXCLUDE_TRYBOTS=tryserver.chromium:win_chromium_compile_dbg 53 CQ_EXCLUDE_TRYBOTS=tryserver.chromium:win_chromium_compile_dbg
54 54
55 CQ_EXCLUDE_TRYBOTS=tryserver.skia:Build-Win7-VS2010-x86-Debug-Trybot 55 CQ_EXCLUDE_TRYBOTS=tryserver.skia:Build-Win7-VS2010-x86-Debug-Trybot
56 56
57 CQ_TRYBOTS 57 CQ_TRYBOTS
58 ---------- 58 ----------
59 59
60 Allows you to list every trybot that you want to run for your CL. 60 Allows you to list every trybot that you want to run for your CL.
61 61
62 This is the format of the values of this keyword: 62 This is the format of the values of this keyword:
63 63
64 CQ_TRYBOTS=master1:bot1,bot2;master2:bot3,bot4 64 CQ_TRYBOTS=master1:bot1,bot2;master2:bot3,bot4
65 65
66 Here are some real world examples: 66 Here are some real world examples:
67 67
68 CQ_TRYBOTS=tryserver.chromium:linux_chromium_gn_rel,linux_chromium_chromeos_ rel, 68 CQ_TRYBOTS=tryserver.chromium:linux_chromium_gn_rel,linux_chromium_chromeos_ rel,
69 android_dbg_triggered_tests,android_dbg,mac_chromium_rel,win_chromium_x64_ rel 69 android_dbg_triggered_tests,android_dbg,mac_chromium_rel,win_chromium_x64_ rel
70 70
71 CQ_TRYBOTS=tryserver.skia:Build-Win7-VS2010-x86-Debug-Trybot, 71 CQ_TRYBOTS=tryserver.skia:Build-Win7-VS2010-x86-Debug-Trybot,
72 Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot, 72 Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot,
73 Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot, 73 Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot,
74 Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot,Build-Mac10.8-Clang-x86_64-Rel ease-Trybot 74 Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot,Build-Mac10.8-Clang-x86_64-Rel ease-Trybot
75 75
76 TBR 76 TBR
77 --- 77 ---
78 78
79 If you are a Skia committer and cannot wait for a review, 79 If you are a Skia committer and cannot wait for a review,
80 then you can include the TBR keyword in your CL's description. 80 then you can include the TBR keyword in your CL's description.
81 81
82 Example: 82 Example:
83 83
84 TBR=rmistry@google.com 84 TBR=rmistry@google.com
85 85
86 NOTREECHECKS 86 NOTREECHECKS
87 ------------ 87 ------------
88 88
89 If you want to skip the tree status checks, to make the CQ commit a CL even if t he tree is closed, 89 If you want to skip the tree status checks, to make the CQ commit a CL even if t he tree is closed,
90 you can add the following line to the CL description: 90 you can add the following line to the CL description:
91 91
92 NOTREECHECKS=true 92 NOTREECHECKS=true
93 93
94 This is discouraged, since the tree is closed for a reason. However, in rare cas es this is acceptable, 94 This is discouraged, since the tree is closed for a reason. However, in rare cas es this is acceptable,
95 primarily to fix build breakages (i.e., your CL will help in reopening the tree) . 95 primarily to fix build breakages (i.e., your CL will help in reopening the tree) .
96 96
97 NOPRESUBMIT 97 CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot (née NOPRESUBMIT)
98 ----------- 98 -----------
99 99
100 If you want to skip the presubmit checks, add the following line to the CL descr iption: 100 If you want to skip the presubmit checks, add the following line to the CL descr iption:
101 101
102 NOPRESUBMIT=true 102 CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot
103 103
104 NOTRY 104 NOTRY
105 ----- 105 -----
106 106
107 If you cannot wait for the try job results, you can add the following line to th e CL description: 107 If you cannot wait for the try job results, you can add the following line to th e CL description:
108 108
109 NOTRY=true 109 NOTRY=true
110 110
111 The CQ will then not run any try jobs for your change and will commit the CL as soon as the tree is open, assuming the presubmit check passes. 111 The CQ will then not run any try jobs for your change and will commit the CL as soon as the tree is open, assuming the presubmit check passes.
112 112
113 NO_MERGE_BUILDS 113 NO_MERGE_BUILDS
114 --------------- 114 ---------------
115 115
116 This keyword prevents the Skia build masters from building this commit with othe rs. Use it when your 116 This keyword prevents the Skia build masters from building this commit with othe rs. Use it when your
117 commit may have effects that you don't want mis-attributed to other commits. Jus t include the keyword 117 commit may have effects that you don't want mis-attributed to other commits. Jus t include the keyword
118 somewhere in the commit message: 118 somewhere in the commit message:
119 119
120 NO_MERGE_BUILDS 120 NO_MERGE_BUILDS
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698