Issue 127133004: Make WebView use new Custom Element callback names exclusively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 127133004: Make WebView use new Custom Element callback names exclusively. (Closed)

Created:
6 years, 11 months ago by dominicc (has gone to gerrit)

Modified:
6 years, 11 months ago

Reviewers:
lazyboy

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make WebView use new Custom Element callback names exclusively. While Custom Element callbacks were being renamed in Blink, WebView had to work with either old or new names. The new names are available post Blink r164213, so it's OK to use the new names exclusively now. BUG=180965 TEST=WebViewTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243829

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -16 lines)			Patch
	M	chrome/renderer/resources/extensions/web_view.js	View		3 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/127133004/1

6 years, 11 months ago (2014-01-08 07:20:05 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243175

6 years, 11 months ago (2014-01-08 08:16:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/127133004/1

6 years, 11 months ago (2014-01-09 00:18:45 UTC) #5

Message was sent while issue was closed.

Change committed as 243829

Expand Messages | Collapse Messages