Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8566)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 127133004: Make WebView use new Custom Element callback names exclusively. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index d827f3fbe2cda853eaa3dbcd20fcc041967bd1b8..f9db94f3953bb6490aa8f8e0a7bc56b278cb2b9c 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -939,10 +939,6 @@ function registerBrowserPluginElement() {
var unused = this.nonExistentAttribute;
};
- // TODO(dominicc): Remove this line once Custom Elements renames
- // enteredViewCallback to attachedCallback
- proto.enteredViewCallback = proto.attachedCallback;
-
WebViewInternal.BrowserPlugin =
DocumentNatives.RegisterElement('browser-plugin', {extends: 'object',
prototype: proto});
@@ -951,12 +947,6 @@ function registerBrowserPluginElement() {
delete proto.attachedCallback;
delete proto.detachedCallback;
delete proto.attributeChangedCallback;
-
- // TODO(dominicc): Remove these lines once Custom Elements renames
- // enteredView, leftView callbacks to attached, detached
- // respectively.
- delete proto.enteredViewCallback;
- delete proto.leftViewCallback;
}
// Registers <webview> custom element.
@@ -1028,12 +1018,6 @@ function registerWebViewElement() {
delete proto.attachedCallback;
delete proto.detachedCallback;
delete proto.attributeChangedCallback;
-
- // TODO(dominicc): Remove these lines once Custom Elements renames
- // enteredView, leftView callbacks to attached, detached
- // respectively.
- delete proto.enteredViewCallback;
- delete proto.leftViewCallback;
}
var useCapture = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698