Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 127133003: Windows: Top-level bubbles no longer appear on taskbar by default. (Closed)

Created:
6 years, 11 months ago by Matt Giuca
Modified:
6 years, 11 months ago
Reviewers:
benwells, sky, dewittj
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, ben+views_chromium.org, sadrul
Visibility:
Public.

Description

Windows: Top-level bubbles no longer appear on taskbar by default. On Windows, Widget::InitParams::force_show_in_taskbar is now respected, so it is possible to override the default without having to directly set HWND properties. This should not change any behaviour (just a refactor). Previously, we had a special case where the message center would turn off showing in taskbar, and app launcher would turn it off for <= Vista. Now we have just one special case: app launcher turns it on for >= Win7. BUG=332277 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243857

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/message_center/message_center_widget_delegate.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 2 chunks +8 lines, -1 line 0 comments Download
M ui/views/widget/widget.h View 1 chunk +0 lines, -2 lines 2 comments Download
M ui/views/widget/widget_hwnd_utils.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Matt Giuca
6 years, 11 months ago (2014-01-08 04:51:32 UTC) #1
sadrul
Nice! But I don't know windows. So sadrul -> sky
6 years, 11 months ago (2014-01-08 04:56:39 UTC) #2
benwells
On 2014/01/08 04:56:39, sadrul wrote: > Nice! But I don't know windows. So sadrul -> ...
6 years, 11 months ago (2014-01-08 05:08:02 UTC) #3
sky
https://codereview.chromium.org/127133003/diff/1/ui/views/widget/widget.h File ui/views/widget/widget.h (left): https://codereview.chromium.org/127133003/diff/1/ui/views/widget/widget.h#oldcode232 ui/views/widget/widget.h:232: bool force_show_in_taskbar; I don't see force_show_in_taskbar in InitParams. When ...
6 years, 11 months ago (2014-01-08 15:11:50 UTC) #4
dewittj
message_center lgtm, thanks for removing my ifdef.
6 years, 11 months ago (2014-01-08 18:20:27 UTC) #5
Matt Giuca
https://codereview.chromium.org/127133003/diff/1/ui/views/widget/widget.h File ui/views/widget/widget.h (left): https://codereview.chromium.org/127133003/diff/1/ui/views/widget/widget.h#oldcode232 ui/views/widget/widget.h:232: bool force_show_in_taskbar; About 2 hours after this comment :) ...
6 years, 11 months ago (2014-01-08 22:53:51 UTC) #6
sky
LGTM
6 years, 11 months ago (2014-01-09 00:28:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/127133003/1
6 years, 11 months ago (2014-01-09 03:50:48 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 12:03:44 UTC) #9
Message was sent while issue was closed.
Change committed as 243857

Powered by Google App Engine
This is Rietveld 408576698