Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: ui/app_list/views/app_list_view.cc

Issue 127133003: Windows: Top-level bubbles no longer appear on taskbar by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/views/app_list_view.cc
diff --git a/ui/app_list/views/app_list_view.cc b/ui/app_list/views/app_list_view.cc
index 8c5850bfdd8b72723ddf162363fb7eaa57dba82b..d471fedda47560b73d02d525a50c08c828aff967 100644
--- a/ui/app_list/views/app_list_view.cc
+++ b/ui/app_list/views/app_list_view.cc
@@ -6,6 +6,7 @@
#include "base/command_line.h"
#include "base/strings/string_util.h"
+#include "base/win/windows_version.h"
#include "ui/app_list/app_list_constants.h"
#include "ui/app_list/app_list_model.h"
#include "ui/app_list/app_list_view_delegate.h"
@@ -321,7 +322,13 @@ void AppListView::OnBeforeBubbleWidgetInit(
if (delegate_ && delegate_->ForceNativeDesktop())
params->native_widget = new views::DesktopNativeWidgetAura(widget);
#endif
-#if defined(OS_LINUX)
+#if defined(OS_WIN)
+ // Windows 7 and higher offer pinning to the taskbar, but we need presence
+ // on the taskbar for the user to be able to pin us. So, show the window on
+ // the taskbar for these versions of Windows.
+ if (base::win::GetVersion() >= base::win::VERSION_WIN7)
+ params->force_show_in_taskbar = true;
+#elif defined(OS_LINUX)
// Set up a custom WM_CLASS for the app launcher window. This allows task
// switchers in X11 environments to distinguish it from main browser windows.
params->wm_class_name = kAppListWMClass;

Powered by Google App Engine
This is Rietveld 408576698