Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1271303002: Fix of 466008: [GN] generate files block second-time ninja build (Closed)

Created:
5 years, 4 months ago by lwchkg
Modified:
5 years, 4 months ago
Reviewers:
mdemp..., Dirk Pranke, brettw, Nico
CC:
grit-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed: The depends file should be written in text mode instead of binary mode (UTF-32-LE). BUG=466008

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M grit/tool/build.py View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 44 (9 generated)
lwchkg
Dear dpranke and others, I've just found the exact problem in issue 466008. Please review ...
5 years, 4 months ago (2015-08-05 14:08:18 UTC) #2
lwchkg
Testing procedure (which I've done myself): 1. Get a Linux checkout with the problem. (That ...
5 years, 4 months ago (2015-08-05 14:15:58 UTC) #3
Dirk Pranke
On 2015/08/05 14:15:58, lwchkg wrote: > Testing procedure (which I've done myself): > 1. Get ...
5 years, 4 months ago (2015-08-05 15:23:08 UTC) #4
brettw
Some related questions: - Are you using cygwin? - Do you have non-ASCII characters in ...
5 years, 4 months ago (2015-08-05 15:54:50 UTC) #5
Dirk Pranke
On 2015/08/05 15:54:50, brettw wrote: > Some related questions: > - Are you using cygwin? ...
5 years, 4 months ago (2015-08-05 15:58:44 UTC) #6
lwchkg
On 2015/08/05 15:23:08, Dirk Pranke wrote: > On 2015/08/05 14:15:58, lwchkg wrote: > > Testing ...
5 years, 4 months ago (2015-08-05 16:00:21 UTC) #7
brettw
Interesting, on my Linux I see 6 bytes. Can you tell me the value of ...
5 years, 4 months ago (2015-08-05 16:04:17 UTC) #8
brettw
(I'm asking because I want to understand this for future reference when doing this kind ...
5 years, 4 months ago (2015-08-05 16:24:39 UTC) #9
lwchkg
On 2015/08/05 16:04:17, brettw wrote: > Interesting, on my Linux I see 6 bytes. Can ...
5 years, 4 months ago (2015-08-05 16:25:04 UTC) #10
lwchkg
On 2015/08/05 16:25:04, lwchkg wrote: > On 2015/08/05 16:04:17, brettw wrote: > > Interesting, on ...
5 years, 4 months ago (2015-08-05 16:26:50 UTC) #11
brettw
> Now it's my turn to ask. What is/are the Linux version(s) you're using? Very ...
5 years, 4 months ago (2015-08-05 16:51:31 UTC) #12
lwchkg
On 2015/08/05 16:51:31, brettw wrote: > > Now it's my turn to ask. What is/are ...
5 years, 4 months ago (2015-08-05 17:25:12 UTC) #13
brettw
On 2015/08/05 17:25:12, lwchkg wrote: > Anyway, by using codecs.open 'w' and 'wb' are the ...
5 years, 4 months ago (2015-08-05 17:33:40 UTC) #14
lwchkg
On 2015/08/05 17:25:12, lwchkg wrote: > On 2015/08/05 16:51:31, brettw wrote: > > > Now ...
5 years, 4 months ago (2015-08-05 17:35:18 UTC) #15
lwchkg
Revised patch is now uploaded.
5 years, 4 months ago (2015-08-05 18:20:03 UTC) #16
brettw
lgtm
5 years, 4 months ago (2015-08-05 19:16:21 UTC) #17
brettw
lgtm lgtm
5 years, 4 months ago (2015-08-05 19:16:21 UTC) #18
Dirk Pranke
One wonders if there is some variation in the way the system python was compiled ...
5 years, 4 months ago (2015-08-05 19:30:57 UTC) #19
lwchkg
On 2015/08/05 19:30:57, Dirk Pranke wrote: > One wonders if there is some variation in ...
5 years, 4 months ago (2015-08-06 02:19:50 UTC) #20
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 4 months ago (2015-08-06 02:29:02 UTC) #27
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 4 months ago (2015-08-06 02:49:02 UTC) #30
lwchkg
Newbie question: How can I get the patch committed? Note: I've tried "git cl dcommit" ...
5 years, 4 months ago (2015-08-06 06:41:46 UTC) #31
Dirk Pranke
On 2015/08/06 02:19:50, lwchkg wrote: > On 2015/08/05 19:30:57, Dirk Pranke wrote: > > One ...
5 years, 4 months ago (2015-08-06 15:41:15 UTC) #32
Dirk Pranke
On 2015/08/06 06:41:46, lwchkg wrote: > Newbie question: How can I get the patch committed? ...
5 years, 4 months ago (2015-08-06 15:42:14 UTC) #33
lwchkg
> It's true that Python can be compiled to store unicode as either 2-byte or ...
5 years, 4 months ago (2015-08-06 16:10:15 UTC) #34
lwchkg
On 2015/08/06 15:42:14, Dirk Pranke wrote: > On 2015/08/06 06:41:46, lwchkg wrote: > > Newbie ...
5 years, 4 months ago (2015-08-06 16:13:03 UTC) #35
haltonhuo
On 2015/08/06 16:10:15, lwchkg wrote: > Sorry I've missed that comment. We may need to ...
5 years, 4 months ago (2015-08-07 08:38:36 UTC) #36
lwchkg
> Hi, I'm the reporter of bug 466008. This bug does appear on Ubuntu 14.10 ...
5 years, 4 months ago (2015-08-07 08:56:27 UTC) #37
Nico
Is it possible to add a test for this?
5 years, 4 months ago (2015-08-07 19:31:52 UTC) #38
lwchkg
On 2015/08/07 19:31:52, Nico (hiding) wrote: > Is it possible to add a test for ...
5 years, 4 months ago (2015-08-09 14:27:56 UTC) #39
lwchkg
On 2015/08/09 14:27:56, lwchkg wrote: > On 2015/08/07 19:31:52, Nico (hiding) wrote: > > Is ...
5 years, 4 months ago (2015-08-09 15:05:47 UTC) #40
Nico
Ah cool, if existing tests catch this on your system, then I'm happy. I'm going ...
5 years, 4 months ago (2015-08-09 21:46:18 UTC) #41
Nico
Landed in grit r193.
5 years, 4 months ago (2015-08-09 21:50:36 UTC) #42
lwchkg
> It's probably a good idea to fix the other failing test too. Okay. I'll ...
5 years, 4 months ago (2015-08-10 09:48:52 UTC) #43
lwchkg
5 years, 4 months ago (2015-08-10 14:11:33 UTC) #44
Message was sent while issue was closed.
I've found that there are more tests failing in Windows. So I started issue
518840 and attached a log there. It's a good idea discuss about the failed tests
there. Of course, the non-ascii unit test still belongs to here.

Powered by Google App Engine
This is Rietveld 408576698