components/password_manager/core/browser/password_form_manager_unittest.cc - Issue 1271283002: Change password form UI for no accounts stored case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 1271283002: Change password form UI for no accounts stored case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cpf_ui

Patch Set: Fix tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc

index 6080ff885124868e7bd9562b7b3114739310f56c..5b2d646db19fb2f4c9fa7e6656f3842e9fcc003c 100644

--- a/components/password_manager/core/browser/password_form_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc

@@ -499,12 +499,11 @@ TEST_F(PasswordFormManagerTest, TestNewLoginFromNewPasswordElement) {

// By this point, the PasswordFormManager should have promoted the new

// password value to be the current password, and should have wiped the

- // password element names: they are likely going to be different on a login

+ // password element name: it is likely going to be different on a login

// form, so it is not worth remembering them.

EXPECT_EQ(credentials.new_password_value,

GetPendingCredentials(&manager)->password_value);

EXPECT_TRUE(GetPendingCredentials(&manager)->password_element.empty());

- EXPECT_TRUE(GetPendingCredentials(&manager)->new_password_element.empty());

EXPECT_TRUE(GetPendingCredentials(&manager)->new_password_value.empty());

}