components/password_manager/core/browser/password_form_manager.cc - Issue 1271283002: Change password form UI for no accounts stored case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 1271283002: Change password form UI for no accounts stored case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cpf_ui

Patch Set: Fix tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.cc

diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc

index 54fa6861c376a7207e317527ce7ecd20296d02b4..dc3964de1d8eb25360a097a1a84981ecfe893154 100644

--- a/components/password_manager/core/browser/password_form_manager.cc

+++ b/components/password_manager/core/browser/password_form_manager.cc

@@ -912,7 +912,6 @@ void PasswordFormManager::CreatePendingCredentials() {

// user goes onto a real login form for the first time.

if (!provisionally_saved_form_->new_password_element.empty()) {

pending_credentials_.password_element.clear();

- pending_credentials_.new_password_element.clear();

}