Document throwInternalError

Document throwInternalError

R=ager@google.com, lukechurch@google.com

Committed: https://github.com/dart-lang/fletch/commit/795e1a212979c22352f792d3244e3af544c42d0b

[ahe, 2015-08-05 07:22:31]

ahe@google.com changed reviewers:
+ ager@google.com, lukechurch@google.com

[Mads Ager (google), 2015-08-05 07:23:50]

LGTM

[ahe, 2015-08-05 07:24:41]

On 2015/08/05 07:23:50, Mads Ager (google) wrote:
> LGTM

Thank you, Mads. I'll give Luke a chance to comment as well.

[lukechurch, 2015-08-05 08:16:06]

lgtm

Is it worth noting that [I presume] we'll automatically include header text as
to how to report this message to us? Similarly to Dart2JS's internal failure
message?

[ahe, 2015-08-05 08:31:55]

On 2015/08/05 08:16:06, lukechurch wrote:
> lgtm
> 
> Is it worth noting that [I presume] we'll automatically include header text as
> to how to report this message to us? Similarly to Dart2JS's internal failure
> message?

Good point. We should also override dart2js' crash message. When dart2js reports
a crash, it's more likely that we caused the problem 

I'll create a bug to track this.

[ahe, 2015-08-05 10:03:09]

Committed patchset #1 (id:1) manually as
795e1a212979c22352f792d3244e3af544c42d0b (presubmit successful).

[ahe, 2015-08-05 10:30:06]

On 2015/08/05 08:31:55, ahe wrote:
> On 2015/08/05 08:16:06, lukechurch wrote:
> > lgtm
> > 
> > Is it worth noting that [I presume] we'll automatically include header text
as
> > to how to report this message to us? Similarly to Dart2JS's internal failure
> > message?
> 
> Good point. We should also override dart2js' crash message. When dart2js
reports
> a crash, it's more likely that we caused the problem 
> 
> I'll create a bug to track this.

Filed https://github.com/dart-lang/fletch/issues/87