Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: chrome/browser/password_manager/password_manager_test_base.cc

Issue 1271053002: [PasswordManager] Fix Flaky BrowserTest related to dynamically created (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_test_base.cc
diff --git a/chrome/browser/password_manager/password_manager_test_base.cc b/chrome/browser/password_manager/password_manager_test_base.cc
index 891dac0cd791ac2f4d6d4faecb2ba410199f85c9..8430b7e5d9a6c87d59f5b8a5d82de354065c2e91 100644
--- a/chrome/browser/password_manager/password_manager_test_base.cc
+++ b/chrome/browser/password_manager/password_manager_test_base.cc
@@ -56,8 +56,30 @@ void NavigationObserver::Wait() {
message_loop_runner_->Run();
}
+PasswordStoreObserver::PasswordStoreObserver(
+ password_manager::TestPasswordStore* password_store)
+ : message_loop_runner_(new content::MessageLoopRunner),
+ test_password_store_(password_store) {
+}
+
+PasswordStoreObserver::~PasswordStoreObserver() {
+}
+
+void PasswordStoreObserver::Wait() {
+ autofill::PasswordForm form;
+ test_password_store_->GetLogins(
+ form, password_manager::PasswordStore::ALLOW_PROMPT, this);
vabr (Chromium) 2015/08/05 08:37:35 Please use DISALLOW_PROMPT instead, to mitigate th
xunlu 2015/08/05 18:37:13 Done.
+ message_loop_runner_->Run();
+}
+
+void PasswordStoreObserver::OnGetPasswordStoreResults(
+ ScopedVector<autofill::PasswordForm> results) {
+ message_loop_runner_->Quit();
+}
+
PromptObserver::PromptObserver() {
}
+
PromptObserver::~PromptObserver() {
}

Powered by Google App Engine
This is Rietveld 408576698