[PasswordManager] Fix Flaky BrowserTest related to dynamically created

chrome/browser/password_manager/password_manager_test_base.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager_test_base.h"
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/infobars/infobar_service.h"
@@ skipping 38 matching lines @@
 void NavigationObserver::NavigationEntryCommitted(
     const content::LoadCommittedDetails& load_details) {
   if (quit_on_entry_committed_)
     message_loop_runner_->Quit();
 }
 
 void NavigationObserver::Wait() {
   message_loop_runner_->Run();
 }
 
+PasswordStoreObserver::PasswordStoreObserver(
+    password_manager::TestPasswordStore* password_store)
+    : message_loop_runner_(new content::MessageLoopRunner),
+      test_password_store_(password_store) {
+}
+
+PasswordStoreObserver::~PasswordStoreObserver() {
+}
+
+void PasswordStoreObserver::Wait() {
+  autofill::PasswordForm form;
+  test_password_store_->GetLogins(
+      form, password_manager::PasswordStore::ALLOW_PROMPT, this);

[vabr (Chromium), 2015/08/05 08:37:35]

Please use DISALLOW_PROMPT instead, to mitigate the risk of getting stuck
because of displaying a user-facing prompt to unlock the keychain.

[xunlu, 2015/08/05 18:37:13]

Done.

+  message_loop_runner_->Run();
+}
+
+void PasswordStoreObserver::OnGetPasswordStoreResults(
+    ScopedVector<autofill::PasswordForm> results) {
+  message_loop_runner_->Quit();
+}
+
 PromptObserver::PromptObserver() {
 }
+
 PromptObserver::~PromptObserver() {
 }
 
 void PromptObserver::Accept() const {
   EXPECT_TRUE(IsShowingPrompt());
   AcceptImpl();
 }
 
 class InfoBarObserver : public PromptObserver,
                         public infobars::InfoBarManager::Observer {
@@ skipping 198 matching lines @@
       "  var element = document.getElementById('%s');"
       "window.domAutomationController.send(element && element.value == '%s');",
       iframe_id.c_str(), iframe_id.c_str(), element_id.c_str(),
       element_id.c_str(), expected_value.c_str());
   bool return_value = false;
   ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
       RenderViewHost(), value_check_script, &return_value));
   EXPECT_TRUE(return_value) << "element_id = " << element_id
                             << ", expected_value = " << expected_value;
 }