Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1271023002: Documentation: C API comments in include/ (Closed)

Created:
5 years, 4 months ago by hal.canary
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2015-09-01 (Tuesday) 13:11:33 EDT #

Total comments: 6

Patch Set 3 : 2015-09-01 (Tuesday) 13:39:17 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -0 lines) Patch
M include/c/sk_canvas.h View 1 2 1 chunk +108 lines, -0 lines 0 comments Download
M include/c/sk_data.h View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M include/c/sk_image.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
M include/c/sk_maskfilter.h View 1 chunk +15 lines, -0 lines 0 comments Download
M include/c/sk_matrix.h View 1 chunk +19 lines, -0 lines 0 comments Download
M include/c/sk_paint.h View 1 2 3 chunks +70 lines, -0 lines 0 comments Download
M include/c/sk_path.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
M include/c/sk_picture.h View 1 chunk +38 lines, -0 lines 0 comments Download
M include/c/sk_surface.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
M include/c/sk_types.h View 1 3 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hal.canary
PTAL
5 years, 4 months ago (2015-08-04 19:09:15 UTC) #2
hal.canary
ping
5 years, 3 months ago (2015-09-01 17:13:19 UTC) #3
reed1
lgtm w/ nits https://codereview.chromium.org/1271023002/diff/20001/include/c/sk_canvas.h File include/c/sk_canvas.h (right): https://codereview.chromium.org/1271023002/diff/20001/include/c/sk_canvas.h#newcode26 include/c/sk_canvas.h:26: allocates an offscreen bitmap. All drawing ...
5 years, 3 months ago (2015-09-01 17:35:15 UTC) #4
hal.canary
https://codereview.chromium.org/1271023002/diff/20001/include/c/sk_canvas.h File include/c/sk_canvas.h (right): https://codereview.chromium.org/1271023002/diff/20001/include/c/sk_canvas.h#newcode26 include/c/sk_canvas.h:26: allocates an offscreen bitmap. All drawing calls are directed ...
5 years, 3 months ago (2015-09-01 17:39:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271023002/40001
5 years, 3 months ago (2015-09-01 17:40:12 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 17:45:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c9119060a0a2739f53b8e966e8fcd9ff58024580

Powered by Google App Engine
This is Rietveld 408576698