Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270993002: fixes #276, path manipulation issues on windows. Also fixes server mode (Closed)

Created:
5 years, 4 months ago by Jennifer Messerly
Modified:
5 years, 4 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #276, path manipulation issues on windows. Also fixes server mode R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ab90b413cb56913d0fb22902424af1bc5497fdca

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -277 lines) Patch
M bin/devc.dart View 1 2 chunks +11 lines, -3 lines 0 comments Download
M bin/devrun.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/compiler.dart View 2 chunks +6 lines, -13 lines 0 comments Download
M lib/src/options.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/server/server.dart View 1 2 3 3 chunks +9 lines, -6 lines 0 comments Download
M test/codegen/expect/js_test.txt View 1 1 chunk +249 lines, -249 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tool/patch_sdk.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jennifer Messerly
5 years, 4 months ago (2015-08-04 17:50:23 UTC) #2
Leaf
https://codereview.chromium.org/1270993002/diff/40001/lib/src/server/server.dart File lib/src/server/server.dart (right): https://codereview.chromium.org/1270993002/diff/40001/lib/src/server/server.dart#newcode260 lib/src/server/server.dart:260: // Never returns I don't follow this comment. Does ...
5 years, 4 months ago (2015-08-04 22:27:59 UTC) #3
Jennifer Messerly
thanks PTAL https://codereview.chromium.org/1270993002/diff/40001/lib/src/server/server.dart File lib/src/server/server.dart (right): https://codereview.chromium.org/1270993002/diff/40001/lib/src/server/server.dart#newcode260 lib/src/server/server.dart:260: // Never returns On 2015/08/04 22:27:59, Leaf ...
5 years, 4 months ago (2015-08-04 22:41:36 UTC) #4
Leaf
lgtm
5 years, 4 months ago (2015-08-04 22:48:13 UTC) #5
Jennifer Messerly
5 years, 4 months ago (2015-08-04 23:34:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
ab90b413cb56913d0fb22902424af1bc5497fdca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698