Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: lib/src/compiler.dart

Issue 1270993002: fixes #276, path manipulation issues on windows. Also fixes server mode (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: fix comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bin/devrun.dart ('k') | lib/src/options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/compiler.dart
diff --git a/lib/src/compiler.dart b/lib/src/compiler.dart
index 926e87412b204a59918612b9e9f1c033f0a7c6f5..6a97b1bd55801639e58daabf64712d34f5ce5c1f 100644
--- a/lib/src/compiler.dart
+++ b/lib/src/compiler.dart
@@ -34,7 +34,6 @@ import 'codegen/html_codegen.dart' as html_codegen;
import 'codegen/js_codegen.dart';
import 'info.dart'
show AnalyzerMessage, CheckerResults, LibraryInfo, LibraryUnit;
-import 'server/server.dart' show DevServer;
import 'options.dart';
import 'report.dart';
@@ -64,18 +63,12 @@ CompilerOptions validateOptions(List<String> args, {bool forceOutDir: false}) {
return options;
}
-Future<bool> compile(CompilerOptions options) async {
- setupLogger(options.logLevel, print);
-
- if (options.serverMode) {
- return new DevServer(options).start();
- } else {
- var context = createAnalysisContextWithSources(
- options.strongOptions, options.sourceOptions);
- var reporter = createErrorReporter(context, options);
- // Note: run returns a bool, turned into a future since this function is async.
- return new BatchCompiler(context, options, reporter: reporter).run();
- }
+bool compile(CompilerOptions options) {
+ assert(!options.serverMode);
+ var context = createAnalysisContextWithSources(
+ options.strongOptions, options.sourceOptions);
+ var reporter = createErrorReporter(context, options);
+ return new BatchCompiler(context, options, reporter: reporter).run();
}
class BatchCompiler extends AbstractCompiler {
« no previous file with comments | « bin/devrun.dart ('k') | lib/src/options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698