Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: Source/core/css/CSSPrimitiveValueMappings.h

Issue 1270723002: Improve CSS Style matching spec compliance (Closed) Base URL: git@github.com:drott/blink-crosswalk.git@reimplementMatching
Patch Set: Fix TestExpectations Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/Source/core/css/CSSPrimitiveValueMappings.h b/Source/core/css/CSSPrimitiveValueMappings.h
index 0f81c156814dcd17afa521841c72c819973b7cb0..ffc899ddf67ff4f27940929bb8f6d2cc292078b5 100644
--- a/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/Source/core/css/CSSPrimitiveValueMappings.h
@@ -3232,6 +3232,9 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(FontStyle italic)
case FontStyleNormal:
m_value.valueID = CSSValueNormal;
return;
+ case FontStyleOblique:
+ m_value.valueID = CSSValueOblique;
+ return;
case FontStyleItalic:
m_value.valueID = CSSValueItalic;
return;
@@ -3246,7 +3249,7 @@ template<> inline CSSPrimitiveValue::operator FontStyle() const
ASSERT(isValueID());
switch (m_value.valueID) {
case CSSValueOblique:
- // FIXME: oblique is the same as italic for the moment...
+ return FontStyleOblique;
case CSSValueItalic:
return FontStyleItalic;
case CSSValueNormal:

Powered by Google App Engine
This is Rietveld 408576698