Source/core/css/CSSFontFaceSource.cpp - Issue 1270723002: Improve CSS Style matching spec compliance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSFontFaceSource.cpp

Issue 1270723002: Improve CSS Style matching spec compliance (Closed) Base URL: git@github.com:drott/blink-crosswalk.git@reimplementMatching

Patch Set: Fix TestExpectations Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSFontFaceSource.cpp

diff --git a/Source/core/css/CSSFontFaceSource.cpp b/Source/core/css/CSSFontFaceSource.cpp

index b7cd589b1d7f00051b30bfa710501f7fed32c86a..e0a7cf4c86b34974e2094b4ee2285c1c247ed1ca 100644

--- a/Source/core/css/CSSFontFaceSource.cpp

+++ b/Source/core/css/CSSFontFaceSource.cpp

@@ -55,6 +55,7 @@ PassRefPtr<SimpleFontData> CSSFontFaceSource::getFontData(const FontDescription&

}

// See if we have a mapping in our FontData cache.

+ // TODO(drott): Check whether losing traits information here is problematic. crbug.com/516677

FontCacheKey key = fontDescription.cacheKey(FontFaceCreationParams());

RefPtr<SimpleFontData>& fontData = m_fontDataTable.add(key.hash(), nullptr).storedValue->value;