Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270533003: Minor cleanup of SkLightingShader (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Minor cleanup of SkLightingShader Fix: PM component swizzling on Macs Serialization Committed: https://skia.googlesource.com/skia/+/c3eb50cd9e9a707b4198b81155ca13e552ec90c0

Patch Set 1 #

Patch Set 2 : Fix registration of SkLightingShader serialization methods #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M src/effects/SkLightingShader.cpp View 1 2 5 chunks +13 lines, -5 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
5 years, 4 months ago (2015-07-30 15:18:04 UTC) #2
reed1
lgtm
5 years, 4 months ago (2015-07-30 16:57:10 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270533003/40001
5 years, 4 months ago (2015-07-30 16:57:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-30 17:04:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270533003/40001
5 years, 4 months ago (2015-07-30 17:11:03 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 17:11:45 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c3eb50cd9e9a707b4198b81155ca13e552ec90c0

Powered by Google App Engine
This is Rietveld 408576698