Issue 1270533002: Make it possible to toggle MSAA for ES (EXT_multisample_compatibility)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1270533002: Make it possible to toggle MSAA for ES (EXT_multisample_compatibility) (Closed)

Created:
5 years, 4 months ago by Kimmo Kinnunen

Modified:
5 years, 4 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Make it possible to toggle MSAA for ES (EXT_multisample_compatibility) Make it possible to turn MSAA on and off for OpenGL ES, too. Use EXT_multisample_compatibility. The extension adds token: MULTISAMPLE_EXT 0x809D The token can be supplied to glEnable/glDisable/glGetInteger. This is needed in order to support mixed samples in OpenGL ES. This is important for path rendering Chromium command buffer integration. Committed: https://skia.googlesource.com/skia/+/bf49e46aca85dc1a0ec089ccaefbb33e7ed6a7d5

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/gpu/gl/GrGLCaps.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270533002/1

5 years, 4 months ago (2015-07-31 05:35:59 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-07-31 05:43:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bf49e46aca85dc1a0ec089ccaefbb33e7ed6a7d5

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages