Issue 127053005: Cleanup: remove Details::window. Use GetTarget() when possible

Issue 127053005: Cleanup: remove Details::window. Use GetTarget() when possible (Closed)

Created:
6 years, 11 months ago by oshima

Modified:
6 years, 11 months ago

Reviewers:
varkha

CC:
chromium-reviews, kalyank, sadrul, dcheng, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup: remove Details::window. Use GetTarget() when possible BUG=none

Patch Set 1 : #

Total comments: 6

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -65 lines)			Patch
M	ash/wm/default_window_resizer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/wm/default_window_resizer.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	ash/wm/dock/docked_window_resizer.cc	View	1 chunk	+3 lines, -3 lines	1 comment	Download
M	ash/wm/drag_window_resizer.cc	View	3 chunks	+3 lines, -3 lines	3 comments	Download
M	ash/wm/panels/panel_window_resizer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/window_resizer.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	ash/wm/window_resizer.cc	View	8 chunks	+16 lines, -14 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	ash/wm/workspace/workspace_window_resizer.cc	View	20 chunks	+36 lines, -33 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

varkha

https://codereview.chromium.org/127053005/diff/11/ash/wm/dock/docked_window_resizer.cc File ash/wm/dock/docked_window_resizer.cc (right): https://codereview.chromium.org/127053005/diff/11/ash/wm/dock/docked_window_resizer.cc#newcode155 ash/wm/dock/docked_window_resizer.cc:155: wm::GetWindowState(details.window())->bounds_changed_by_user()), Should GetTarget be used here and below? https://codereview.chromium.org/127053005/diff/11/ash/wm/drag_window_resizer.cc ...

6 years, 11 months ago (2014-01-08 23:46:56 UTC) #2

abandoning in favor of crrev.com/121153003

Expand Messages | Collapse Messages