content/common/service_worker/service_worker_messages.h - Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass a raw ptr to callback's onError instead of a scoped_ptr. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/web_service_worker_registration_impl.cc ('k') | content/common/service_worker/service_worker_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index 66024f8aa1fd4134966b73dcb21ba5a20c8ff44a..ef4e5e9ad122d39a6461f26b4d3769a3ea427f6b 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -138,7 +138,9 @@ IPC_MESSAGE_CONTROL5(ServiceWorkerHostMsg_RegisterServiceWorker,

GURL /* scope */,

GURL /* script_url */)

-IPC_MESSAGE_CONTROL2(ServiceWorkerHostMsg_UpdateServiceWorker,

+IPC_MESSAGE_CONTROL4(ServiceWorkerHostMsg_UpdateServiceWorker,

+ int /* thread_id */,

+ int /* request_id */,

int /* provider_id */,

int64 /* registration_id */)

@@ -321,6 +323,11 @@ IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_ServiceWorkerRegistered,

content::ServiceWorkerRegistrationObjectInfo,

content::ServiceWorkerVersionAttributes)

+// Response to ServiceWorkerHostMsg_UpdateServiceWorker.

+IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_ServiceWorkerUpdated,

+ int /* thread_id */,

+ int /* request_id */)

// Response to ServiceWorkerHostMsg_UnregisterServiceWorker.

IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_ServiceWorkerUnregistered,

int /* thread_id */,

@@ -356,6 +363,14 @@ IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_ServiceWorkerRegistrationError,

blink::WebServiceWorkerError::ErrorType /* code */,

base::string16 /* message */)

+// Sent when any kind of update error occurs during a

+// UpdateServiceWorker handler above.

+IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_ServiceWorkerUpdateError,

+ int /* thread_id */,

+ int /* request_id */,

+ blink::WebServiceWorkerError::ErrorType /* code */,

+ base::string16 /* message */)

// Sent when any kind of registration error occurs during a

// UnregisterServiceWorker handler above.

IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_ServiceWorkerUnregistrationError,