content/child/service_worker/web_service_worker_registration_impl.cc - Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.cc

Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass a raw ptr to callback's onError instead of a scoped_ptr. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/web_service_worker_registration_impl.h ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_registration_impl.cc

diff --git a/content/child/service_worker/web_service_worker_registration_impl.cc b/content/child/service_worker/web_service_worker_registration_impl.cc

index 99addd0cf50a225b5388e973f35c0de89575bca1..1b4b610cb6894f376dd92c0135306550d64719fe 100644

--- a/content/child/service_worker/web_service_worker_registration_impl.cc

+++ b/content/child/service_worker/web_service_worker_registration_impl.cc

@@ -114,14 +114,15 @@ blink::WebURL WebServiceWorkerRegistrationImpl::scope() const {

}

void WebServiceWorkerRegistrationImpl::update(

- blink::WebServiceWorkerProvider* provider) {

+ blink::WebServiceWorkerProvider* provider,

+ WebServiceWorkerUpdateCallbacks* callbacks) {

WebServiceWorkerProviderImpl* provider_impl =

static_cast<WebServiceWorkerProviderImpl*>(provider);

ServiceWorkerDispatcher* dispatcher =

ServiceWorkerDispatcher::GetThreadSpecificInstance();

DCHECK(dispatcher);

dispatcher->UpdateServiceWorker(provider_impl->provider_id(),

- registration_id());

+ registration_id(), callbacks);

}

void WebServiceWorkerRegistrationImpl::unregister(