content/child/service_worker/web_service_worker_registration_impl.h - Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.h

Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass a raw ptr to callback's onError instead of a scoped_ptr. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_dispatcher.cc ('k') | content/child/service_worker/web_service_worker_registration_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_registration_impl.h

diff --git a/content/child/service_worker/web_service_worker_registration_impl.h b/content/child/service_worker/web_service_worker_registration_impl.h

index 67ecc1a5393a2ea8f80ae45a94a37926ec16751d..6546c89a332f9d735ac6cfcc7b41c6eee6a2b9af 100644

--- a/content/child/service_worker/web_service_worker_registration_impl.h

+++ b/content/child/service_worker/web_service_worker_registration_impl.h

@@ -39,7 +39,8 @@ class CONTENT_EXPORT WebServiceWorkerRegistrationImpl

virtual void setProxy(blink::WebServiceWorkerRegistrationProxy* proxy);

virtual blink::WebServiceWorkerRegistrationProxy* proxy();

virtual blink::WebURL scope() const;

- virtual void update(blink::WebServiceWorkerProvider* provider);

+ virtual void update(blink::WebServiceWorkerProvider* provider,

+ WebServiceWorkerUpdateCallbacks* callbacks);

virtual void unregister(blink::WebServiceWorkerProvider* provider,

WebServiceWorkerUnregistrationCallbacks* callbacks);