chrome/browser/chromeos/login/webui_login_display.cc - Issue 12704002: Support for auth code based authentication flow for both app and web UI driven flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/webui_login_display.cc

Issue 12704002: Support for auth code based authentication flow for both app and web UI driven flow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/oauth_login_manager.h ('K') | « chrome/browser/chromeos/login/webui_login_display.h ('k') | chrome/browser/chromeos/login/webui_screen_locker.h » ('j') | chrome/browser/resources/chromeos/login/screen_gaia_signin.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/webui_login_display.cc

diff --git a/chrome/browser/chromeos/login/webui_login_display.cc b/chrome/browser/chromeos/login/webui_login_display.cc

index b80a28eec43964c831ab7b479c10b286f5b736d0..db0e18c376d4b9d9cd4df15ef5c4de6175d336b2 100644

--- a/chrome/browser/chromeos/login/webui_login_display.cc

+++ b/chrome/browser/chromeos/login/webui_login_display.cc

@@ -225,18 +225,16 @@ void WebUILoginDisplay::CreateAccount() {

delegate_->CreateAccount();

}

-void WebUILoginDisplay::CompleteLogin(const std::string& username,

- const std::string& password) {

+void WebUILoginDisplay::CompleteLogin(const UserCredentials& credentials) {

DCHECK(delegate_);

if (delegate_)

- delegate_->CompleteLogin(username, password);

+ delegate_->CompleteLogin(credentials);

}

-void WebUILoginDisplay::Login(const std::string& username,

- const std::string& password) {

+void WebUILoginDisplay::Login(const UserCredentials& credentials) {

DCHECK(delegate_);

if (delegate_)

- delegate_->Login(username, password);

+ delegate_->Login(credentials);

}

void WebUILoginDisplay::LoginAsRetailModeUser() {