chrome/browser/resources/chromeos/login/screen_gaia_signin.js - Issue 12704002: Support for auth code based authentication flow for both app and web UI driven flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Issue 12704002: Support for auth code based authentication flow for both app and web UI driven flow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/oauth_login_manager.h ('K') | « chrome/browser/chromeos/login/webui_screen_locker.cc ('k') | chrome/browser/resources/gaia_auth/main.js » ('j') | chrome/common/chrome_switches.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/screen_gaia_signin.js

diff --git a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

index 2cba058e766814938836a51685ac139e22037e6e..541a291df2e4900a17e0ce2893745ca758a68036 100644

--- a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

+++ b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

@@ -314,6 +314,13 @@ cr.define('login', function() {

Oobe.getInstance().headerHidden = true;

// Clear any error messages that were shown before login.

Oobe.clearErrors();

+ } else if (msg.method == 'completeAuthentication') {

+ chrome.send('completeAuthentication', [msg.email, msg.authCode]);

xiyuan 2013/03/20 20:08:29 nit: 2-space indent from previous line.

zel 2013/03/20 21:03:38 Done.

+ this.loading = true;

+ // Now that we're in logged in state header should be hidden.

+ Oobe.getInstance().headerHidden = true;

+ // Clear any error messages that were shown before login.

+ Oobe.clearErrors();

} else if (msg.method == 'loginUILoaded') {

this.loading = false;

chrome.send('loginScreenUpdate');