Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 1270393003: [GC] Align behavior of JSProxy with JSObject when embedded in optimized code (Closed)

Created:
5 years, 4 months ago by Michael Lippautz
Modified:
5 years, 4 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[GC] Align behavior of JSProxy with JSObject when embedded in optimized code With --harmony-proxies enabled, embedded pointers in optimized code can point to a JSProxy (via a cell). Since JSProxy can morph into JSObject we need to align the expectations of weak vs strong refs. With this patch we also treat JSPRoxy as weak ref (like JSObject) and therefore properly record a dependency on it, so that once the cell pointing to it becomes unreachable we deoptimize the corresponding code. BUG=v8:4359 LOG=N Committed: https://crrev.com/a039ff2930cbe6881360925e4debc959c7db392a Cr-Commit-Position: refs/heads/master@{#30067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/objects-inl.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Lippautz
Fixes the issue Yang was seeing in v8:4359.
5 years, 4 months ago (2015-08-07 12:20:16 UTC) #2
ulan
LGTM, good catch!
5 years, 4 months ago (2015-08-07 12:22:42 UTC) #3
Hannes Payer (out of office)
On 2015/08/07 12:22:42, ulan wrote: > LGTM, good catch! Lgtm
5 years, 4 months ago (2015-08-07 12:26:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270393003/1
5 years, 4 months ago (2015-08-07 12:26:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 12:54:54 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 12:55:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a039ff2930cbe6881360925e4debc959c7db392a
Cr-Commit-Position: refs/heads/master@{#30067}

Powered by Google App Engine
This is Rietveld 408576698