src/objects-inl.h - Issue 1270393003: [GC] Align behavior of JSProxy with JSObject when embedded in optimized code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1270393003: [GC] Align behavior of JSProxy with JSObject when embedded in optimized code (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 3a9fe2991decc352c34f79a0635ce1968a57539f..f9c0f460922fea8428b7ca6cc987ecec020e3259 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -4735,7 +4735,8 @@ bool Code::IsWeakObjectInOptimizedCode(Object* object) {

} else if (object->IsPropertyCell()) {

object = PropertyCell::cast(object)->value();

}

- if (object->IsJSObject()) {

+ if (object->IsJSObject() || object->IsJSProxy()) {

+ // JSProxy is handled like JSObject because it can morph into one.

return FLAG_weak_embedded_objects_in_optimized_code;

}

if (object->IsFixedArray()) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »