Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270393002: [strong] Refactor out separate strong runtime call for class objects (Closed)

Created:
5 years, 4 months ago by conradw
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Refactor out separate strong runtime call for class objects BUG=v8:3956 LOG=N Committed: https://crrev.com/2cd2b8cadb4ebafefd4969c99853a3d7fd9d4906 Cr-Commit-Position: refs/heads/master@{#30033}

Patch Set 1 #

Total comments: 2

Patch Set 2 : cl feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -55 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 1 chunk +8 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
conradw
PTAL
5 years, 4 months ago (2015-08-05 14:14:00 UTC) #2
rossberg
lgtm https://codereview.chromium.org/1270393002/diff/1/src/runtime/runtime-classes.cc File src/runtime/runtime-classes.cc (right): https://codereview.chromium.org/1270393002/diff/1/src/runtime/runtime-classes.cc#newcode266 src/runtime/runtime-classes.cc:266: RETURN_FAILURE_ON_EXCEPTION(isolate, JSObject::Freeze(prototype)); How about adding a DCHECK(prototype->map()->is_strong()) here?
5 years, 4 months ago (2015-08-05 14:25:58 UTC) #3
conradw
https://codereview.chromium.org/1270393002/diff/1/src/runtime/runtime-classes.cc File src/runtime/runtime-classes.cc (right): https://codereview.chromium.org/1270393002/diff/1/src/runtime/runtime-classes.cc#newcode266 src/runtime/runtime-classes.cc:266: RETURN_FAILURE_ON_EXCEPTION(isolate, JSObject::Freeze(prototype)); On 2015/08/05 14:25:58, rossberg wrote: > How ...
5 years, 4 months ago (2015-08-05 14:30:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270393002/20001
5 years, 4 months ago (2015-08-05 15:38:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-05 16:04:03 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 16:05:04 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2cd2b8cadb4ebafefd4969c99853a3d7fd9d4906
Cr-Commit-Position: refs/heads/master@{#30033}

Powered by Google App Engine
This is Rietveld 408576698