Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 1270393002: [strong] Refactor out separate strong runtime call for class objects (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2459 matching lines...) Expand 10 before | Expand all | Expand 10 after
2470 2470
2471 case ObjectLiteral::Property::SETTER: 2471 case ObjectLiteral::Property::SETTER:
2472 __ push(Immediate(Smi::FromInt(DONT_ENUM))); 2472 __ push(Immediate(Smi::FromInt(DONT_ENUM)));
2473 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4); 2473 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
2474 break; 2474 break;
2475 } 2475 }
2476 } 2476 }
2477 2477
2478 // Set both the prototype and constructor to have fast properties, and also 2478 // Set both the prototype and constructor to have fast properties, and also
2479 // freeze them in strong mode. 2479 // freeze them in strong mode.
2480 __ CallRuntime(is_strong(language_mode()) 2480 __ CallRuntime(Runtime::kFinalizeClassDefinition, 2);
2481 ? Runtime::kFinalizeClassDefinitionStrong
2482 : Runtime::kFinalizeClassDefinition,
2483 2);
2484 } 2481 }
2485 2482
2486 2483
2487 void FullCodeGenerator::EmitBinaryOp(BinaryOperation* expr, Token::Value op) { 2484 void FullCodeGenerator::EmitBinaryOp(BinaryOperation* expr, Token::Value op) {
2488 __ pop(edx); 2485 __ pop(edx);
2489 Handle<Code> code = 2486 Handle<Code> code =
2490 CodeFactory::BinaryOpIC(isolate(), op, strength(language_mode())).code(); 2487 CodeFactory::BinaryOpIC(isolate(), op, strength(language_mode())).code();
2491 JumpPatchSite patch_site(masm_); // unbound, signals no inlined smi code. 2488 JumpPatchSite patch_site(masm_); // unbound, signals no inlined smi code.
2492 CallIC(code, expr->BinaryOperationFeedbackId()); 2489 CallIC(code, expr->BinaryOperationFeedbackId());
2493 patch_site.EmitPatchInfo(); 2490 patch_site.EmitPatchInfo();
(...skipping 2841 matching lines...) Expand 10 before | Expand all | Expand 10 after
5335 Assembler::target_address_at(call_target_address, 5332 Assembler::target_address_at(call_target_address,
5336 unoptimized_code)); 5333 unoptimized_code));
5337 return OSR_AFTER_STACK_CHECK; 5334 return OSR_AFTER_STACK_CHECK;
5338 } 5335 }
5339 5336
5340 5337
5341 } // namespace internal 5338 } // namespace internal
5342 } // namespace v8 5339 } // namespace v8
5343 5340
5344 #endif // V8_TARGET_ARCH_X87 5341 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698