Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 12703032: Revert 146744 "Refactoring: Pull Node::disabled() and Node::isIn..." (Closed)

Created:
7 years, 9 months ago by kareng
Modified:
7 years, 9 months ago
Reviewers:
falken
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1453/
Visibility:
Public.

Description

Revert 146744 "Refactoring: Pull Node::disabled() and Node::isIn..." > Refactoring: Pull Node::disabled() and Node::isInert() down to Element. > https://bugs.webkit.org/show_bug.cgi?id=112085 > > Reviewed by Hajime Morrita. > > Node is too low a level for these methods. The plan is to rename > Element::disabled to isDisabledFormControl and to remove > Element::isEnabledFormControl. > > No new tests, just refactoring. > > * dom/Element.cpp: > (WebCore::Element::disabled): > (WebCore): > (WebCore::Element::isInert): > * dom/Element.h: > (Element): > * dom/EventDispatcher.cpp: > (WebCore::EventDispatcher::dispatchSimulatedClick): > * dom/GestureEvent.cpp: > (WebCore::GestureEventDispatchMediator::dispatchEvent): > * dom/MouseEvent.cpp: > (WebCore::MouseEventDispatchMediator::dispatchEvent): > * dom/Node.cpp: > (WebCore::Node::handleLocalEvents): > (WebCore::Node::willRespondToMouseMoveEvents): > (WebCore::Node::willRespondToMouseClickEvents): > (WebCore::Node::willRespondToTouchEvents): > * dom/Node.h: > (Node): > TBR=falken@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146892

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -36 lines) Patch
M Source/WebCore/dom/Element.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/WebCore/dom/Element.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M Source/WebCore/dom/EventDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/dom/GestureEvent.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/WebCore/dom/MouseEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/dom/Node.h View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Node.cpp View 5 chunks +21 lines, -4 lines 0 comments Download
M Source/WebCore/rendering/RenderThemeMac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
7 years, 9 months ago (2013-03-26 15:57:59 UTC) #1
kareng
7 years, 9 months ago (2013-03-26 15:58:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r146892.

Powered by Google App Engine
This is Rietveld 408576698