Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270103003: Fix SkData leaks at GrResourceKey::setCustomData() call sites. (Closed)

Created:
5 years, 4 months ago by senorblanco
Modified:
5 years, 4 months ago
Reviewers:
bsalomon, Stephen White
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SkData leaks at GrResourceKey::setCustomData() call sites. BUG=skia: TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/c369348aa596d7be05c9ce0ca5d349e5d1903789

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270103003/1
5 years, 4 months ago (2015-08-04 01:42:05 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-04 01:50:16 UTC) #4
senorblanco
Committed patchset #1 (id:1) manually as c369348aa596d7be05c9ce0ca5d349e5d1903789 (presubmit successful).
5 years, 4 months ago (2015-08-04 01:53:13 UTC) #5
bsalomon
On 2015/08/04 01:53:13, senorblanco wrote: > Committed patchset #1 (id:1) manually as > c369348aa596d7be05c9ce0ca5d349e5d1903789 (presubmit ...
5 years, 4 months ago (2015-08-04 13:41:46 UTC) #6
mtklein_C
5 years, 4 months ago (2015-08-04 15:17:49 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1262623008/ by mtklein@chromium.org.

The reason for reverting is: reverting this chain, lots of big diffs.

Powered by Google App Engine
This is Rietveld 408576698