[Net] Propagate priority changes from URLRequest to HttpTransaction

net/url_request/url_request_ftp_job.h

Index: net/url_request/url_request_ftp_job.h
diff --git a/net/url_request/url_request_ftp_job.h b/net/url_request/url_request_ftp_job.h
index 3b053c1e190ab61823a43babecdd196151b4807d..92b17b71e73c9427b9b748a4d546b7a12037dad8 100644
--- a/net/url_request/url_request_ftp_job.h
+++ b/net/url_request/url_request_ftp_job.h
@@ -9,6 +9,7 @@
 
 #include "base/memory/weak_ptr.h"
 #include "net/base/auth.h"
+#include "net/base/net_export.h"
 #include "net/ftp/ftp_request_info.h"
 #include "net/ftp/ftp_transaction.h"
 #include "net/http/http_request_info.h"
@@ -25,7 +26,7 @@ class FtpAuthCache;
 
 // A URLRequestJob subclass that is built on top of FtpTransaction. It
 // provides an implementation for FTP.
-class URLRequestFtpJob : public URLRequestJob {
+class NET_EXPORT_PRIVATE URLRequestFtpJob : public URLRequestJob {
  public:
   URLRequestFtpJob(URLRequest* request,
                    NetworkDelegate* network_delegate,
@@ -43,9 +44,17 @@ class URLRequestFtpJob : public URLRequestJob {
   virtual void GetResponseInfo(HttpResponseInfo* info) OVERRIDE;
   virtual HostPortPair GetSocketAddress() const OVERRIDE;

[mmenke, 2013/03/20 17:12:59]

While you're here, seems kinda weird that there are public, and the other
URLRequestJob functions are not.  Looks to me that these can be protected,
too...

[akalin, 2013/03/21 01:30:33]

Done.

 
- private:
+ protected:
   virtual ~URLRequestFtpJob();
 
+  // Overridden from URLRequestJob:
+  virtual void SetPriority(RequestPriority priority) OVERRIDE;
+  virtual void Start() OVERRIDE;
+  virtual void Kill() OVERRIDE;
+
+  RequestPriority priority_;

[mmenke, 2013/03/20 17:12:59]

optional:  Think it's a little better to give this a const accessor, and make
the variable private, to make it clear subclasses don't set it.

[akalin, 2013/03/21 01:30:33]

Well, subclasses can just call SetPriority(), but sure. Done.

+
+ private:
   void OnResolveProxyComplete(int result);
 
   void StartFtpTransaction();
@@ -60,8 +69,6 @@ class URLRequestFtpJob : public URLRequestJob {
   void LogFtpServerType(char server_type);
 
   // Overridden from URLRequestJob:
-  virtual void Start() OVERRIDE;
-  virtual void Kill() OVERRIDE;
   virtual LoadState GetLoadState() const OVERRIDE;
   virtual bool NeedsAuth() OVERRIDE;
   virtual void GetAuthChallengeInfo(