[Net] Propagate priority changes from URLRequest to HttpTransaction

net/url_request/url_request_ftp_job.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
 
 #include <string>
 
 #include "base/memory/weak_ptr.h"
 #include "net/base/auth.h"
+#include "net/base/net_export.h"
 #include "net/ftp/ftp_request_info.h"
 #include "net/ftp/ftp_transaction.h"
 #include "net/http/http_request_info.h"
 #include "net/http/http_transaction.h"
 #include "net/proxy/proxy_info.h"
 #include "net/proxy/proxy_service.h"
 #include "net/url_request/url_request_job.h"
 
 namespace net {
 
 class NetworkDelegate;
 class FtpTransactionFactory;
 class FtpAuthCache;
 
 // A URLRequestJob subclass that is built on top of FtpTransaction. It
 // provides an implementation for FTP.
-class URLRequestFtpJob : public URLRequestJob {
+class NET_EXPORT_PRIVATE URLRequestFtpJob : public URLRequestJob {
  public:
   URLRequestFtpJob(URLRequest* request,
                    NetworkDelegate* network_delegate,
                    FtpTransactionFactory* ftp_transaction_factory,
                    FtpAuthCache* ftp_auth_cache);
 
   // TODO(shalev): get rid of this function in favor of FtpProtocolHandler.
   static URLRequestJob* Factory(URLRequest* request,
                                 NetworkDelegate* network_delegate,
                                 const std::string& scheme);
 
   // Overridden from URLRequestJob:
   virtual bool IsSafeRedirect(const GURL& location) OVERRIDE;
   virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
   virtual void GetResponseInfo(HttpResponseInfo* info) OVERRIDE;
   virtual HostPortPair GetSocketAddress() const OVERRIDE;

[mmenke, 2013/03/20 17:12:59]

While you're here, seems kinda weird that there are public, and the other
URLRequestJob functions are not.  Looks to me that these can be protected,
too...

[akalin, 2013/03/21 01:30:33]

Done.

 
- private:
+ protected:
   virtual ~URLRequestFtpJob();
 
+  // Overridden from URLRequestJob:
+  virtual void SetPriority(RequestPriority priority) OVERRIDE;
+  virtual void Start() OVERRIDE;
+  virtual void Kill() OVERRIDE;
+
+  RequestPriority priority_;

[mmenke, 2013/03/20 17:12:59]

optional:  Think it's a little better to give this a const accessor, and make
the variable private, to make it clear subclasses don't set it.

[akalin, 2013/03/21 01:30:33]

Well, subclasses can just call SetPriority(), but sure. Done.

+
+ private:
   void OnResolveProxyComplete(int result);
 
   void StartFtpTransaction();
   void StartHttpTransaction();
 
   void OnStartCompleted(int result);
   void OnStartCompletedAsync(int result);
   void OnReadCompleted(int result);
 
   void RestartTransactionWithAuth();
 
   void LogFtpServerType(char server_type);
 
   // Overridden from URLRequestJob:
-  virtual void Start() OVERRIDE;
-  virtual void Kill() OVERRIDE;
   virtual LoadState GetLoadState() const OVERRIDE;
   virtual bool NeedsAuth() OVERRIDE;
   virtual void GetAuthChallengeInfo(
       scoped_refptr<AuthChallengeInfo>* auth_info) OVERRIDE;
   virtual void SetAuth(const AuthCredentials& credentials) OVERRIDE;
   virtual void CancelAuth() OVERRIDE;
 
   // TODO(ibrar):  Yet to give another look at this function.
   virtual UploadProgress GetUploadProgress() const OVERRIDE;
   virtual bool ReadRawData(IOBuffer* buf,
@@ skipping 18 matching lines @@
 
   FtpTransactionFactory* ftp_transaction_factory_;
   FtpAuthCache* ftp_auth_cache_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestFtpJob);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_