[Net] Propagate priority changes from URLRequest to HttpTransaction

net/url_request/url_request_http_job.h

Index: net/url_request/url_request_http_job.h
diff --git a/net/url_request/url_request_http_job.h b/net/url_request/url_request_http_job.h
index 8020625e14c67b4d3ebae22b28ae63a5ab40d04b..206eba92b9ccc4227cbc256234ad387bef733a34 100644
--- a/net/url_request/url_request_http_job.h
+++ b/net/url_request/url_request_http_job.h
@@ -9,11 +9,13 @@
 #include <vector>
 
 #include "base/compiler_specific.h"
+#include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time.h"
 #include "net/base/auth.h"
 #include "net/base/completion_callback.h"
+#include "net/base/net_export.h"
 #include "net/cookies/cookie_store.h"
 #include "net/http/http_request_info.h"
 #include "net/url_request/url_request_job.h"
@@ -30,7 +32,7 @@ class URLRequestContext;
 
 // A URLRequestJob subclass that is built on top of HttpTransaction.  It
 // provides an implementation for both HTTP and HTTPS.
-class URLRequestHttpJob : public URLRequestJob {
+class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
  public:
   static URLRequestJob* Factory(URLRequest* request,
                                 NetworkDelegate* network_delegate,
@@ -98,6 +100,7 @@ class URLRequestHttpJob : public URLRequestJob {
   virtual void DoneReading() OVERRIDE;
   virtual HostPortPair GetSocketAddress() const OVERRIDE;
   virtual void NotifyURLRequestDestroyed() OVERRIDE;
+  virtual void SetPriority(RequestPriority priority) OVERRIDE;
 
   HttpRequestInfo request_info_;
   const HttpResponseInfo* response_info_;
@@ -141,6 +144,8 @@ class URLRequestHttpJob : public URLRequestJob {
   bool is_cached_content_;
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(URLRequestHttpJob, Priority);

[mmenke, 2013/03/12 18:40:22]

Rather than maintain a list of every URLRequestHttpJob here (Which, admittedly,
is currently rather short), why don't we just make a child class of
URLRequestHttpJob in the test file.  It can have an accessor for transaction_,
which is already protected.

Alternatively, you could add a text fixture and friend that.  I tend to prefer
the inheritance route, since friending functions exposes more, and adds stuff to
the header, but I'm fine with either approach.

[akalin, 2013/03/12 22:08:28]

I prefer the latter, since inheriting from the class you're testing can have
inadvertent effects. Done.

+
   enum CompletionCause {
     ABORTED,
     FINISHED