[Net] Propagate priority changes from URLRequest to HttpTransaction

net/url_request/url_request_http_job.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
 
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
+#include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time.h"
 #include "net/base/auth.h"
 #include "net/base/completion_callback.h"
+#include "net/base/net_export.h"
 #include "net/cookies/cookie_store.h"
 #include "net/http/http_request_info.h"
 #include "net/url_request/url_request_job.h"
 #include "net/url_request/url_request_throttler_entry_interface.h"
 
 namespace net {
 
 class HttpResponseHeaders;
 class HttpResponseInfo;
 class HttpTransaction;
 class HttpUserAgentSettings;
 class UploadDataStream;
 class URLRequestContext;
 
 // A URLRequestJob subclass that is built on top of HttpTransaction.  It
 // provides an implementation for both HTTP and HTTPS.
-class URLRequestHttpJob : public URLRequestJob {
+class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
  public:
   static URLRequestJob* Factory(URLRequest* request,
                                 NetworkDelegate* network_delegate,
                                 const std::string& scheme);
 
  protected:
   URLRequestHttpJob(URLRequest* request,
                     NetworkDelegate* network_delegate,
                     const HttpUserAgentSettings* http_user_agent_settings);
 
@@ skipping 47 matching lines @@
   virtual void SetAuth(const AuthCredentials& credentials) OVERRIDE;
   virtual void CancelAuth() OVERRIDE;
   virtual void ContinueWithCertificate(X509Certificate* client_cert) OVERRIDE;
   virtual void ContinueDespiteLastError() OVERRIDE;
   virtual bool ReadRawData(IOBuffer* buf, int buf_size,
                            int* bytes_read) OVERRIDE;
   virtual void StopCaching() OVERRIDE;
   virtual void DoneReading() OVERRIDE;
   virtual HostPortPair GetSocketAddress() const OVERRIDE;
   virtual void NotifyURLRequestDestroyed() OVERRIDE;
+  virtual void SetPriority(RequestPriority priority) OVERRIDE;
 
   HttpRequestInfo request_info_;
   const HttpResponseInfo* response_info_;
 
   std::vector<std::string> response_cookies_;
   size_t response_cookies_save_index_;
   base::Time response_date_;
 
   // Auth states for proxy and origin server.
   AuthState proxy_auth_state_;
@@ skipping 23 matching lines @@
   // For SDCH latency experiments, when we are able to do SDCH, we may enable
   // either an SDCH latency test xor a pass through test.  The following bools
   // indicate what we decided on for this instance.
   bool sdch_test_activated_;  // Advertising a dictionary for sdch.
   bool sdch_test_control_;    // Not even accepting-content sdch.
 
   // For recording of stats, we need to remember if this is cached content.
   bool is_cached_content_;
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(URLRequestHttpJob, Priority);

[mmenke, 2013/03/12 18:40:22]

Rather than maintain a list of every URLRequestHttpJob here (Which, admittedly,
is currently rather short), why don't we just make a child class of
URLRequestHttpJob in the test file.  It can have an accessor for transaction_,
which is already protected.

Alternatively, you could add a text fixture and friend that.  I tend to prefer
the inheritance route, since friending functions exposes more, and adds stuff to
the header, but I'm fine with either approach.

[akalin, 2013/03/12 22:08:28]

I prefer the latter, since inheriting from the class you're testing can have
inadvertent effects. Done.

+
   enum CompletionCause {
     ABORTED,
     FINISHED
   };
 
   typedef base::RefCountedData<bool> SharedBoolean;
 
   class HttpFilterContext;
   class HttpTransactionDelegateImpl;
 
@@ skipping 95 matching lines @@
   scoped_ptr<HttpTransactionDelegateImpl> http_transaction_delegate_;
 
   const HttpUserAgentSettings* http_user_agent_settings_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_